dimas-b commented on code in PR #3339:
URL: https://github.com/apache/polaris/pull/3339#discussion_r2653938225
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCacheKey.java:
##########
@@ -53,7 +53,7 @@ public interface StorageCredentialCacheKey {
Optional<String> refreshCredentialsEndpoint();
@Value.Parameter(order = 8)
- Optional<String> principalName();
+ Optional<PolarisPrincipal> principal();
Review Comment:
> I guess the only actual solution I see for these sorts of issues is to
delegate key generation to Integration classes themselves
Yes, I actually thought about that exact approach too. I agree that it's
ultimately the better solution.
I'm going to close this PR. I think there is no bug in current cache
behaviour. Let's go for the proper solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
