dimas-b commented on code in PR #3347:
URL: https://github.com/apache/polaris/pull/3347#discussion_r2661901797
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/azure/AzureCredentialsStorageIntegration.java:
##########
@@ -165,6 +167,17 @@ public StorageAccessConfig getSubscopedCreds(
blobSasPermission,
Mono.just(accessToken));
} else if
(location.getEndpoint().equalsIgnoreCase(AzureLocation.ADLS_ENDPOINT)) {
+ String path = null;
+ if (Boolean.TRUE.equals(config().isHierarchical())) {
+ Preconditions.checkArgument(
+ allowedReadLocations.size() <= 1,
+ "Allowed read locations must not have more that one entry");
+ Preconditions.checkArgument(
+ allowedWriteLocations.size() <= 1,
+ "Allowed write locations must not have more that one entry");
Review Comment:
> what is the use case for several allowedReadLocations and
allowedWriteLocations?
TBH, I do not really know :sweat_smile: Currently, only one location is
passed in.
Azure can restrict SAS to only location (base directory or specific file).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
