dimas-b commented on code in PR #3350:
URL: https://github.com/apache/polaris/pull/3350#discussion_r2662295239
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/NamespaceEntity.java:
##########
@@ -75,8 +77,23 @@ public String getBaseLocation() {
}
public static class Builder extends
PolarisEntity.BaseBuilder<NamespaceEntity, Builder> {
+
+ private static final int MAX_NAMESPACE_DEPTH = 10;
+
public Builder(Namespace namespace) {
super();
+ Preconditions.checkArgument(namespace != null, "Namespace must not be
null");
+
+ int depth = namespace.length();
+ if (depth > MAX_NAMESPACE_DEPTH) {
Review Comment:
I do not think namespace depth is the critical parameter for #3243. It's
rather the total policy size, of which the table's full Polaris name is a
factor (but not the only factor). I do not think restricting namespace depth
will fix #3243.
Moreover, #3243 is specific to AWS. Any fix for #3243 should ideally not
impact other storage systems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
