dimas-b commented on code in PR #3357:
URL: https://github.com/apache/polaris/pull/3357#discussion_r2662334382
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java:
##########
@@ -60,6 +61,14 @@ public FileIO loadFileIO(
properties.putAll(storageAccessConfig.extraProperties());
properties.putAll(storageAccessConfig.internalProperties());
+ // Disable AWS SDK trailing checksum validation if explicitly configured
+ String enableTrailingChecksums =
+ properties.getOrDefault("s3.enable-trailing-checksums", "true");
+
+ if (!Boolean.parseBoolean(enableTrailingChecksums)) {
+ properties.put(S3FileIOProperties.CHECKSUM_VALIDATION_ENABLED, "false");
Review Comment:
It is probably preferable to handle FileIO-related config via
`StorageAccessConfig`. This way it will apply both to Polaris and clients
(engines).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
