flyrain commented on code in PR #3340:
URL: https://github.com/apache/polaris/pull/3340#discussion_r2670309352
##########
runtime/service/src/main/java/org/apache/polaris/service/config/ProductionReadinessChecks.java:
##########
@@ -75,6 +76,10 @@ public void warnOnFailedChecks(
@Observes Startup event,
Instance<ProductionReadinessCheck> checks,
ReadinessConfiguration config) {
+ // Skip production readiness checks in CLI mode - they're only relevant
for server deployments
+ if (ConfigUtils.isProfileActive("cli")) {
Review Comment:
That's probably a good idea, esp. if we want to group a set of methods under
the same configure key, instead of spreed `if
(ConfigUtils.isProfileActive("cli")` in multiple places. We could improve in
followups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
