dimas-b commented on code in PR #3395: URL: https://github.com/apache/polaris/pull/3395#discussion_r2677045033
########## runtime/admin/src/main/resources/application.properties: ########## @@ -40,7 +40,24 @@ quarkus.rds.sync-client.type=apache # ---- Runtime Configuration ---- # Below are default values for properties that can be changed in runtime. +# Available types: +# - in-memory - InMemoryPolarisMetaStoreManagerFactory +# - in-memory-atomic - InMemoryAtomicOperationMetaStoreManagerFactory +# - relational-jdbc - JdbcMetaStoreManagerFactory +# - nosql - NoSQL persistence backend, define the backend type via 'polaris.persistence.nosql.backend' polaris.persistence.type=relational-jdbc +# Database backend for 'nosql' persistence-type +# Available backends: +# - InMemory - for testing purposes +# - MongoDb - configure the via the Quarkus extension +polaris.persistence.nosql.backend=InMemory + +## MongoDB version store specific configuration +quarkus.mongodb.database=polaris +quarkus.mongodb.metrics.enabled=true +#quarkus.mongodb.connection-string=mongodb://localhost:27017 +quarkus.mongodb.devservices.enabled=false Review Comment: Is it a runtime setting or build-time (the latter have a dedicated section)? ########## runtime/admin/src/main/java/org/apache/polaris/admintool/maintenance/NoSqlMaintenanceCommand.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.admintool.maintenance; + +import picocli.CommandLine; + [email protected]( + name = "maintenance", + subcommands = { + NoSqlMaintenanceLogCommand.class, + NoSqlMaintenanceRunCommand.class, + }, + mixinStandardHelpOptions = true, + description = "Polaris persistence maintenance.") Review Comment: Should we flag it as "beta" as discussed in the last community sync call?.. or perhaps "preview" since the actually persistence storage that can be maintained via this command has not been hooked up yet (IIRC). ########## runtime/admin/src/main/resources/application.properties: ########## @@ -50,10 +67,13 @@ quarkus.datasource.devservices.enabled=false quarkus.arc.ignored-split-packages=\ org.apache.polaris.admintool.config,\ + org.apache.polaris.admintool.maintenance,\ Review Comment: Could we refactor this code to avoid split packages upfront? ########## runtime/admin/src/main/resources/application.properties: ########## @@ -40,7 +40,24 @@ quarkus.rds.sync-client.type=apache # ---- Runtime Configuration ---- # Below are default values for properties that can be changed in runtime. +# Available types: +# - in-memory - InMemoryPolarisMetaStoreManagerFactory +# - in-memory-atomic - InMemoryAtomicOperationMetaStoreManagerFactory +# - relational-jdbc - JdbcMetaStoreManagerFactory +# - nosql - NoSQL persistence backend, define the backend type via 'polaris.persistence.nosql.backend' polaris.persistence.type=relational-jdbc +# Database backend for 'nosql' persistence-type +# Available backends: +# - InMemory - for testing purposes +# - MongoDb - configure the via the Quarkus extension +polaris.persistence.nosql.backend=InMemory + +## MongoDB version store specific configuration Review Comment: `MongoDB version store specific configuration defaults`? I suppose the user can change any of these settings. ########## runtime/admin/src/main/java/org/apache/polaris/admintool/maintenance/NoSqlMaintenanceRunCommand.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.admintool.maintenance; + +import jakarta.inject.Inject; +import org.apache.polaris.persistence.nosql.maintenance.api.MaintenanceService; +import picocli.CommandLine; + [email protected]( + name = "run", + mixinStandardHelpOptions = true, + description = {"Run Polaris persistence maintenance."}) Review Comment: maybe `Run Polaris NoSQL persistence maintenance` for the sake of clarity? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
