dimas-b commented on code in PR #3396:
URL: https://github.com/apache/polaris/pull/3396#discussion_r2677073955
##########
runtime/service/src/main/java/org/apache/polaris/service/persistence/PersistenceConfiguration.java:
##########
@@ -31,7 +31,7 @@ public interface PersistenceConfiguration {
*/
String type();
- @WithDefault("in-memory")
+ @WithDefault("in-memory,nosql")
Review Comment:
I'm not sure enabling auto-bootstrap for all `nosql` backends is correct...
I believe it is preferable to direct users to bootstrapping via the Admin tool
on real storage.
Can we handle this in test code for now and refactor later to make it
default for nosql+inmemory?
##########
runtime/defaults/src/main/resources/application.properties:
##########
@@ -255,6 +263,11 @@ polaris.credential-manager.type=default
polaris.iceberg-metrics.reporting.type=default
# Set to INFO if you want to see iceberg metric reports logged
quarkus.log.category."org.apache.polaris.service.reporting".level=OFF
+## MongoDB version store specific configuration
+quarkus.mongodb.database=polaris
+quarkus.mongodb.metrics.enabled=true
+#quarkus.mongodb.connection-string=mongodb://localhost:27017
+quarkus.mongodb.devservices.enabled=false
Review Comment:
Quite a few Quarkus `devservices` config properties have to be set at
build-time... Should we move this setting to the build-time section (above)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
