snazy commented on code in PR #3411:
URL: https://github.com/apache/polaris/pull/3411#discussion_r2681221765
##########
runtime/service/src/main/java/org/apache/polaris/service/config/ServiceProducers.java:
##########
@@ -285,7 +287,13 @@ public void maybeBootstrap(
RootCredentialsSet.ENVIRONMENT_VARIABLE,
RootCredentialsSet.SYSTEM_PROPERTY);
- var result = factory.bootstrapRealms(realmIds, rootCredentialsSet);
+ HashMap<String, PrincipalSecretsResult> result = new HashMap<>();
+ for (String realmId : realmIds) {
+ PrincipalSecretsResult r = bootstrapper.bootstrapRealm(realmId,
rootCredentialsSet);
+ if (r != null) {
+ result.put(realmId, r);
+ }
+ }
result.forEach(
Review Comment:
Looks like this function doesn't really need `Map<> results` anymore, only
to populate `unusedRealmSecrets` below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
