dimas-b commented on code in PR #3414:
URL: https://github.com/apache/polaris/pull/3414#discussion_r2683266846
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/io/StorageAccessConfigProvider.java:
##########
@@ -187,6 +189,24 @@ private CredentialVendingContext
buildCredentialVendingContext(
builder.activatedRoles(Optional.of(rolesString));
}
+ // Extract OpenTelemetry trace ID for end-to-end correlation
+ // This enables correlation between credential vending (CloudTrail),
catalog operations
+ // (Polaris events), and metrics reports from compute engines
+ builder.traceId(getCurrentTraceId());
Review Comment:
Any parameters that affect the vended credential must be part of the cache
key for the sake of correctness.
A feature flag is required for users to turn off trace IDs in tags and have
better cache efficiency if they wish so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
