RussellSpitzer commented on code in PR #3396: URL: https://github.com/apache/polaris/pull/3396#discussion_r2683570828
########## runtime/defaults/src/main/resources/application.properties: ########## @@ -128,16 +131,27 @@ polaris.features."SUPPORTED_CATALOG_CONNECTION_TYPES"=["ICEBERG_REST"] # realm overrides # polaris.features.realm-overrides."my-realm"."SKIP_CREDENTIAL_SUBSCOPING_INDIRECTION"=true -# polaris.persistence.type=in-memory-atomic +# Available types: +# - in-memory - InMemoryPolarisMetaStoreManagerFactory +# - in-memory-atomic - InMemoryAtomicOperationMetaStoreManagerFactory +# - nosql (beta) - NoSQL persistence backend, define the backend type via 'polaris.persistence.nosql.backend' +# - relational-jdbc polaris.persistence.type=in-memory -# polaris.persistence.type=relational-jdbc +# Database backend for 'nosql' persistence-type +# Available backends: +# - InMemory - for testing purposes +# - MongoDb - configure the via the Quarkus extension +polaris.persistence.nosql.backend=InMemory Review Comment: That was basically my thought, I generally would keep properties unset unless they do something. So in this case we have a property that's set but doesn't actually do anything because other config stops it from being valid. Like how we do in the cloudwatch config ``` # AWS CloudWatch event listener settings # polaris.event-listener.type=aws-cloudwatch # polaris.event-listener.aws-cloudwatch.log-group=polaris-cloudwatch-default-group # polaris.event-listener.aws-cloudwatch.log-stream=polaris-cloudwatch-default-stream # polaris.event-listener.aws-cloudwatch.region=us-east-1 # polaris.event-listener.aws-cloudwatch.synchronous-mode=false ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
