adutra commented on code in PR #3412:
URL: https://github.com/apache/polaris/pull/3412#discussion_r2690009025
##########
runtime/admin/src/main/java/org/apache/polaris/admintool/config/AdminToolProducers.java:
##########
@@ -75,4 +77,10 @@ public PolarisConfigurationStore configurationStore() {
// A configuration store is not required when running the admin tool.
return new PolarisConfigurationStore() {};
}
+
+ @Produces
+ public RealmConfig dummyRealmConfig(PolarisConfigurationStore
configurationStore) {
+ // Use "unknown" realm ID for RealmConfig since the
PolarisConfigurationStore is empty anyway
+ return new RealmConfigImpl(configurationStore, () -> "unknown");
Review Comment:
Would this be a problem if a realm with this exact name actually existed?
Maybe a special `RealmConfig` implementation would be more appropriate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
