dimas-b commented on code in PR #3459:
URL: https://github.com/apache/polaris/pull/3459#discussion_r2699843395
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCacheKey.java:
##########
@@ -84,7 +81,6 @@ static StorageCredentialCacheKey of(
allowedListAction,
allowedReadLocations,
allowedWriteLocations,
- refreshCredentialsEndpoint,
Review Comment:
This certainly fixes the multiple STS calls, however the cache returns a
`StorageAccessConfig`, which may indirectly contain the
`refreshCredentialsEndpoint`. This change may cause cache hits to return
`StorageAccessConfig` objects without or without the
`refreshCredentialsEndpoint` that the caller does not expect. Note that
`refreshCredentialsEndpoint` is a parameter to
`StorageCredentialCache.getOrGenerateSubScopeCreds()` ... WDYT?
That said, #3292 is actually a pretty tricky problem to fix... I believe it
requires substantial code refactoring 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
