obelix74 commented on PR #3385:
URL: https://github.com/apache/polaris/pull/3385#issuecomment-3762605440
> > > @obelix74 : Re: splitting into two PRs - if it's not too much
overhead, it might be preferable from my POV. I think persistence impl. may be
a bit more involved as I commented above.
> >
> >
> > On it. Moving this PR to draft until the event PR is merged and this
branch / PR is rebased against main.
>
> @dimas-b Raised #3468
@dimas-b I have further redone this PR into the following distinct commits.
The feat/add-metrics-persistence-handler branch now contains 7
well-organized commits:
| Commit | Message | Files | Purpose |
|--------|---------|-------|---------|
| 132ca9bdd | feat(events): Enable metrics event emission in
reportMetrics() | 8 | PR#1 - Feature flag + event types |
| 1954427f6 | feat(events): Add metrics persistence handler for
AFTER_REPORT_METRICS events | 2 | PR#2 - Basic event listener |
| bf37017e8 | feat(persistence): Add database schema and model classes
for metrics (PR#3) | 9 | Schema v4 + model classes |
| c04e60e7d | feat(persistence): Add JDBC persistence implementation for
metrics (PR#4) | 4 | JDBC layer + tests |
| ed8b10718 | feat(reporting): Add metrics reporters infrastructure
(PR#5) | 11 | Reporters + configuration |
| 6def4a499 | feat(cleanup): Add metrics cleanup service and
documentation (PR#6) | 2 | Cleanup service + docs |
| 553045dc1 | test(integration): Update
InMemoryBufferEventListenerIntegrationTest | 1 | Integration tests |
PR#1 is #3468.
If need be, we can separate out each one of these self-contained commits
into their own PRs for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
