obelix74 commented on PR #3468:
URL: https://github.com/apache/polaris/pull/3468#issuecomment-3769556238
@adutra and @dimas-b thanks for all the feedback. Indeed, @singhpk234 also
did not like the event based approach. I have made the following changes to
address your feedback.
* Introduces a new MetricsProcessor interface with CDI support. This
establishes the foundation for a simpler, more direct metrics processing
architecture. I have intentionally left out `PolarisMetricsReporter`.
* MetricsProcessingContext - Rich context object providing:
• Catalog and table information
• Realm ID and principal name
• Request ID for correlation
• OpenTelemetry trace ID and span ID
• Timestamp
• MetricsProcessorConfiguration - Type-safe configuration using Quarkus
@ConfigMapping
• CDI producer in ServiceProducers for MetricsProcessor selection via
@Identifier annotations
The existing PolarisMetricsReporter interface and
polaris.iceberg-metrics.reporting.type configuration remain unchanged and
functional. This PR only removes the experimental event-based approach that was
added in feature branches.
**What's Not Included**
This PR intentionally excludes implementations to keep the scope focused:
• No processor implementations (noop, logging, persistence)
• No integration with IcebergCatalogAdapter
• No backward compatibility adapters
These will be added in subsequent PRs.
Configuration
```
polaris:
metrics:
processor:
type: noop # Default - implementations will be added in follow-up
PRs
```
Next Steps
Follow-up PRs will add:
1. Built-in processor implementations (noop, logging, persistence)
2. Integration with the REST catalog adapter
3. Backward compatibility layer for existing PolarisMetricsReporter users
I am open to removing `PolarisMetricsReporter` - but need to figure out how
to migrate existing code and users. In fact, I just upgraded my Polaris
installation to `1.3.0` to use the metrics logging output while we sort out
these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
