yj-lee0503 opened a new pull request, #3480: URL: https://github.com/apache/polaris/pull/3480
<!-- ๐ Describe what changes you're proposing, especially breaking or user-facing changes. ๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more. --> ## Summary - pass ExternalCatalog properties through federation factories (Iceberg REST, Hive, Hadoop) - merge catalog properties with connection config, with connection config taking precedence - document proxy/timeout settings for Iceberg REST federation - add tests that exercise production merge logic ## Context External catalog properties such as `rest.client.proxy.*` and timeout settings were not reaching the Iceberg REST HTTP client. This blocks federation in controlled egress environments. ## Changes - add a shared merge helper in `IcebergRESTExternalCatalogFactory` and use it for initialization - honor ExternalCatalog properties for Hive/Hadoop federation as well - update docs with supported proxy/timeout keys and CLI examples ## Tests - `./gradlew format compileAll` - `./gradlew rat` - `./gradlew :polaris-core:test` - `./gradlew :polaris-extensions-federation-hadoop:test` (NO-SOURCE) - `./gradlew :polaris-extensions-federation-hive:test` (NO-SOURCE) - `./gradlew :polaris-runtime-service:test` **fails** with 4 failures in `AwsCloudWatchEventListenerTest` (Testcontainers/Docker initialization issue; unrelated) ## Notes - This changes an external extension point (`ExternalCatalogFactory`). Per CONTRIBUTING, I plan to discuss this on the dev mailing list before marking the PR ready for review. - `CLAUDE.md` is excluded from RAT and remains untracked. Related to #3465 ## Checklist - [ ] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [ ] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes # - [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [ ] ๐ก Added comments for complex logic - [ ] ๐งพ Updated `CHANGELOG.md` (if needed) - [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
