dimas-b commented on code in PR #3456:
URL: https://github.com/apache/polaris/pull/3456#discussion_r2709467313
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -1092,6 +1098,10 @@ public void commitTransaction(CommitTransactionRequest
commitTransactionRequest)
if (!updatedMetadata.changes().isEmpty()) {
tableOps.commit(currentMetadata, updatedMetadata);
}
+
+ LoadTableResponse loadTableResponse =
+
LoadTableResponse.builder().withTableMetadata(updatedMetadata).build();
Review Comment:
From my POV event payload does not have to match REST API payload. I
actually think it is preferable for Polaris to define a separate API for event
payloads because those are generated by Polaris, and generally follow the
evolution of Polaris internal code rather than the evolution of the Iceberg
REST API. For example, moving to a new REST API revision does not have to mean
that all event payloads get adjustments.
Similarly if Polaris were to support multiple REST API revisions at the same
time, it would be nice to have one stream of events with the same payloads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
