MonkeyCanCode commented on code in PR #3496:
URL: https://github.com/apache/polaris/pull/3496#discussion_r2711126456
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java:
##########
@@ -124,6 +124,13 @@ public URI getStsEndpointUri() {
return getStsEndpoint() == null ? getInternalEndpointUri() :
URI.create(getStsEndpoint());
}
+ @JsonIgnore
+ public boolean isAwsS3() {
+ String endpoint = getEndpoint();
+ // AWS S3 if no endpoint is specified or if it uses an amazonaws.com
endpoint
+ return endpoint == null || endpoint.contains(".amazonaws.com");
Review Comment:
Usually AWS endpoint will be a pretty wide set of IPs and those IP can
changed too as far as I know. I can't think about a reason on why we would ever
want to pin a specific IP for using AWS endpoint as they all have geo routing
already. But that is fair if somehow a user really wants to pined to a specific
AWS IP address, this won't add wildcard KMS policy (as it will then get
classified as non-AWS S3). But if user did specified KMS key on the catalog
property, this will then work normally again with more detailed KMS policies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
