pingtimeout commented on code in PR #3503: URL: https://github.com/apache/polaris/pull/3503#discussion_r2715973229
########## CHANGELOG.md: ########## @@ -98,7 +109,6 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti ### New Features -- Added KMS properties (optional) to catalog storage config to enable S3 data encryption. Review Comment: This change surprised me at first. We should not be modifying the 1.2.0-incubating section as part of this PR, ideally. But it turns out the be necessary. But it turns out that the changelog was updated in the wrong section for fb9397f1a2. The `Added KMS properties (optional) to catalog storage config to enable S3 data encryption.` bullet point should have been added to the `Unreleased` section for inclusion in the 1.3.0 release notes. But it had been added to the `1.2.0-incubating` section instead, which was already released at the time the PR was merged. Could you re-add this bullet point, but in the `1.3.0-incubatiing` section? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
