binarycat0 commented on code in PR #136: URL: https://github.com/apache/polaris-tools/pull/136#discussion_r2716229646
########## console/docker/Dockerfile: ########## @@ -13,22 +13,21 @@ # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or implied. See the License for the # specific language governing permissions and limitations -# under the License. +# under the License. Review Comment: Extra whitespace ########## console/docker/Dockerfile: ########## @@ -1,7 +1,7 @@ # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file +# regarding copyright ownership. The ASF licenses this file Review Comment: Extra whitespace? ########## console/docker/Dockerfile: ########## @@ -13,22 +13,21 @@ # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or implied. See the License for the # specific language governing permissions and limitations -# under the License. +# under the License. # Build stage -FROM registry.access.redhat.com/ubi9/nodejs-22-minimal:9.7-1767673763 AS builder +FROM node:22-slim AS builder Review Comment: AFAIK this image was used in purpose. Please check this PR - https://github.com/apache/polaris-tools/commit/34e63e682b41b4ff9566c5db803d30e9fa73e15f ########## console/docker/Dockerfile: ########## @@ -13,22 +13,21 @@ # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or implied. See the License for the # specific language governing permissions and limitations -# under the License. +# under the License. # Build stage -FROM registry.access.redhat.com/ubi9/nodejs-22-minimal:9.7-1767673763 AS builder +FROM node:22-slim AS builder -# Default environment variables (can be overridden at runtime) +# Set default environment variables (can be overridden at runtime) ENV VITE_POLARIS_API_URL=http://polaris:8181 ENV VITE_POLARIS_REALM=POLARIS -ENV VITE_POLARIS_PRINCIPAL_SCOPE=PRINCIPAL_ROLE:ALL -ENV VITE_OAUTH_TOKEN_URL=http://polaris:8181/api/catalog/v1/oauth/tokens +ENV VITE_OAUTH_TOKEN_URL= ENV VITE_POLARIS_REALM_HEADER_NAME=Polaris-Realm WORKDIR /app # Copy package files -COPY package.json ./ +COPY package. json ./ Review Comment: Extra whitespace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
