ajantha-bhat commented on PR #135:
URL: https://github.com/apache/polaris-tools/pull/135#issuecomment-3791151460

   @snazy: Thanks a lot for the review. 
   
   > We have a bunch of independent projects in polaris-tools, so I think it's 
better to change the group-ID to 
org.apache.polaris.tools.iceberg-catalog-migrator so it has it's "own 
namespace" that doesn't conflict with other tools.
   
   That makes sense — having a distinct namespace per tool is reasonable.
   To stay aligned with Apache and Java package conventions, would you be open 
to using a dot-separated subgroup instead, e.g. 
`org.apache.polaris.tools.iceberg.catalog.migrator`, with 
`iceberg-catalog-migrator` remaining as the artifactId?
   
   > I don't see that the signing-extension (the signatory) being configured - 
neither with a secret-key/password combination nor via the optional useGpgAgent 
project property.
   
   Done. And verified Signing with new options. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to