snazy commented on code in PR #3507: URL: https://github.com/apache/polaris/pull/3507#discussion_r2723874978
########## CHANGELOG.md: ########## @@ -31,9 +31,12 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti ### Upgrade notes +- The custom token-bucket based rate limiter has been replaced with Guava's rate limiter implementation. + ### Breaking changes - The (Before/After)CommitTableEvent has been removed. +- The configuration option `polaris.rate-limiter.token-bucket.window` is no longer supported and should be removed. Review Comment: I thought about that, too. However, people should remove it now (or better: with the next release) to be safe for the release after that. Sure, it's not really breaking, however, the parameter is no longer used - could be a interpreted as "a soft breaking change" (not sure there's a better term for that). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
