RussellSpitzer commented on PR #3396:
URL: https://github.com/apache/polaris/pull/3396#issuecomment-3800508923

   > Re: indexing properties:
   > 
   > > Is it necessitated by this PR? That's my only big question here, It's 
not obvious to me why the other changes in this PR caused this issue
   > 
   > This PR integrates NoSQL code into the `runtime/server` module where 
Quarkus starts introspecting this code and issues the 
[warning](https://github.com/apache/polaris/pull/3396#discussion_r2727978172). 
Quarkus did not introspect this code until it was part of the server build.
   > 
   > I'd say we ought to fix the warning from Quarkus in order to be sure that 
its introspection yields a complete picture for CDI to function properly. As I 
noted above, not having this property does not lead to any visible breakage, 
however, I think it is much safer to set it in order to benefit from Quarkus 
build-time checks to the full extent.
   
   We should definitely include it then. I just wasn't clear on whether this 
had been present before this PR or not, if the other changes pulls in this as a 
build warning then we should keep it in this PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to