dimas-b commented on code in PR #3554:
URL: https://github.com/apache/polaris/pull/3554#discussion_r2733334618
##########
runtime/service/src/main/java/org/apache/polaris/service/events/PolarisEventType.java:
##########
@@ -145,8 +145,8 @@ public enum PolarisEventType {
AFTER_RENAME_VIEW,
BEFORE_REPLACE_VIEW,
AFTER_REPLACE_VIEW,
- BEFORE_COMMIT_VIEW,
- AFTER_COMMIT_VIEW,
+ BEFORE_COMMIT_VIEW, // REMOVED FROM SOURCE CODE
Review Comment:
I do not see any particular issues with changing ordinals. AFAIK, Polaris
does not use java serialization for this enum and Jackson deals with names.
##########
runtime/service/src/main/java/org/apache/polaris/service/events/PolarisEventType.java:
##########
@@ -145,8 +145,8 @@ public enum PolarisEventType {
AFTER_RENAME_VIEW,
BEFORE_REPLACE_VIEW,
AFTER_REPLACE_VIEW,
- BEFORE_COMMIT_VIEW,
- AFTER_COMMIT_VIEW,
+ BEFORE_COMMIT_VIEW, // REMOVED FROM SOURCE CODE
Review Comment:
I do not see any particular issue with changing ordinals. AFAIK, Polaris
does not use java serialization for this enum and Jackson deals with names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
