binarycat0 commented on code in PR #147:
URL: https://github.com/apache/polaris-tools/pull/147#discussion_r2737217287
##########
console/src/api/auth.ts:
##########
@@ -21,14 +21,11 @@ import axios from "axios"
import { apiClient } from "./client"
import { navigate } from "@/lib/navigation"
import { REALM_HEADER_NAME } from "@/lib/constants"
+import { config } from "@/lib/config"
import type { OAuthTokenResponse } from "@/types/api"
-// Always use relative URL to go through the proxy (dev server or production
server)
-// This avoids CORS issues by proxying requests through the server
-// The server.ts proxy handles /api routes in production, and Vite handles
them in development
-const TOKEN_URL = "/api/catalog/v1/oauth/tokens"
+const TOKEN_URL = `${config.POLARIS_API_URL}/api/catalog/v1/oauth/tokens`
Review Comment:
Hello. Thank you for the review. I gree that this URL should be
configurable, and as I know there is already an Issue particularly for that
case.
Also, there is an additional PR that aiming to redesign whole configuration
flow - https://github.com/apache/polaris-tools/pull/138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
