adutra commented on code in PR #3603:
URL: https://github.com/apache/polaris/pull/3603#discussion_r2740991392
##########
getting-started/telemetry/docker-compose.yml:
##########
@@ -95,7 +95,7 @@ services:
environment:
- COLLECTOR_OTLP_ENABLED=true
Review Comment:
I think this environment variable is not necessary anymore. The OLTP
collector is now enabled by default.
##########
getting-started/telemetry/docker-compose.yml:
##########
@@ -95,7 +95,7 @@ services:
environment:
- COLLECTOR_OTLP_ENABLED=true
healthcheck:
- test: "echo -e 'GET / HTTP/1.1\\r\\nHost: localhost\\r\\nConnection:
close\\r\\n\\r\\n' | nc localhost 16686 | grep -q '200 OK'"
+ test: ["CMD", "wget", "-qO-", "http://localhost:13133/status";]
Review Comment:
For posterity: 13133 is the standard OpenTelemetry health check port:
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/extension/healthcheckextension/README.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
