dimas-b commented on code in PR #3395: URL: https://github.com/apache/polaris/pull/3395#discussion_r2748562827
########## runtime/admin/src/main/java/org/apache/polaris/admintool/nosql/maintenance/NoSqlMaintenanceInfoCommand.java: ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.admintool.nosql.maintenance; + +import picocli.CommandLine; + [email protected]( + name = "maintenance-info", Review Comment: nit: Maybe add `maintenance` as another sub-command group? Current: `java -jar ... nosql maintenance-info` Proposed: `java -jar ... nosql maintenance info` I hope the latter in nicer in terms of UX. ########## runtime/admin/src/main/resources/application.properties: ########## @@ -40,7 +40,24 @@ quarkus.rds.sync-client.type=apache # ---- Runtime Configuration ---- # Below are default values for properties that can be changed in runtime. +# Available types: +# - in-memory - InMemoryPolarisMetaStoreManagerFactory +# - in-memory-atomic - InMemoryAtomicOperationMetaStoreManagerFactory +# - relational-jdbc - JdbcMetaStoreManagerFactory +# - nosql - NoSQL persistence backend, define the backend type via 'polaris.persistence.nosql.backend' polaris.persistence.type=relational-jdbc +# Database backend for 'nosql' persistence-type +# Available backends: +# - InMemory - for testing purposes +# - MongoDb - configure the via the Quarkus extension +polaris.persistence.nosql.backend=InMemory + +## MongoDB version store specific configuration +quarkus.mongodb.database=polaris +quarkus.mongodb.metrics.enabled=true +#quarkus.mongodb.connection-string=mongodb://localhost:27017 +quarkus.mongodb.devservices.enabled=false Review Comment: Per https://quarkus.io/guides/mongodb-dev-services `quarkus.mongodb.devservices.enabled` is a build-time config. Please move to the `Build-time configuration` section (lines 20-38) for the sake of consistency. ########## runtime/admin/src/main/java/org/apache/polaris/admintool/nosql/NoSqlCommand.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.admintool.nosql; + +import jakarta.inject.Inject; +import org.apache.polaris.admintool.nosql.maintenance.NoSqlMaintenanceInfoCommand; +import org.apache.polaris.admintool.nosql.maintenance.NoSqlMaintenanceLogCommand; +import org.apache.polaris.admintool.nosql.maintenance.NoSqlMaintenanceRunCommand; +import org.apache.polaris.persistence.nosql.api.backend.Backend; +import picocli.CommandLine; + [email protected]( + name = "nosql", + subcommands = { + NoSqlMaintenanceInfoCommand.class, + NoSqlMaintenanceLogCommand.class, + NoSqlMaintenanceRunCommand.class, + }, + mixinStandardHelpOptions = true, + description = "Polaris NoSQL persistence.") Review Comment: nit: suggestion: `Sub-commands specific to NoSQL persistence.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
