obelix74 commented on code in PR #3616: URL: https://github.com/apache/polaris/pull/3616#discussion_r2761917119
########## polaris-core/src/main/java/org/apache/polaris/core/persistence/metrics/ScanMetricsRecord.java: ########## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.persistence.metrics; + +import java.time.Instant; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import org.apache.polaris.immutables.PolarisImmutable; + +/** + * Backend-agnostic representation of an Iceberg scan metrics report. + * + * <p>This record captures all relevant metrics from an Iceberg {@code ScanReport} along with + * contextual information such as realm, catalog, and request correlation data. + */ +@PolarisImmutable +public interface ScanMetricsRecord { + + // === Identification === + + /** Unique identifier for this report (UUID). */ + String reportId(); + + /** Multi-tenancy realm identifier. */ + String realmId(); + + /** Internal catalog ID. */ + String catalogId(); + + /** Human-readable catalog name. */ + String catalogName(); Review Comment: For table identification: Using Iceberg's TableIdentifier instead of separate namespace/tableName strings. This encapsulates both namespace path and table name, aligns with Iceberg patterns, and is consistent with `TableLikeEntity.getTableIdentifier()`. For catalog identification: Keeping catalogId (long) and catalogName (String) as separate primitives rather than using CatalogEntity. Rationale: 1. Heavyweight object: CatalogEntity extends PolarisEntity and includes storage config, properties, internal properties, timestamps, grant records version - none relevant for metrics identification 2. Immutables incompatibility: CatalogEntity is a class wrapping PolarisBaseEntity, not a @PolarisImmutable interface. The Immutables annotation processor cannot generate proper builders that include it - I can't figure out a solution for this. 3. Serialization complexity: CatalogEntity uses @JsonCreator/@JsonProperty annotations that don't integrate cleanly with Immutables-generated classes 4. Minimal data needed: For metrics records, we only need catalog ID (for foreign key relationships) and name (for display/query convenience) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
