dimas-b commented on code in PR #3663:
URL: https://github.com/apache/polaris/pull/3663#discussion_r2764598427
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/CatalogFederationIntegrationTest.java:
##########
@@ -423,7 +424,7 @@ void testFederatedCatalogWithCredentialVending() {
// Verify that write is blocked since the vended credential should only
have read permission
assertThatThrownBy(() -> spark.sql("INSERT INTO ns1.test_table VALUES (3,
'Charlie')"))
.hasMessageContaining(
- "software.amazon.awssdk.services.s3.model.S3Exception: Access
Denied. (Service: S3, Status Code: 403,");
+ "software.amazon.awssdk.services.s3.model.S3Exception: Access
Denied (Service: S3, Status Code: 403,");
Review Comment:
Suggestion: user RegEx for account for both cases.
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/CatalogFederationIntegrationTest.java:
##########
@@ -423,7 +424,7 @@ void testFederatedCatalogWithCredentialVending() {
// Verify that write is blocked since the vended credential should only
have read permission
assertThatThrownBy(() -> spark.sql("INSERT INTO ns1.test_table VALUES (3,
'Charlie')"))
.hasMessageContaining(
- "software.amazon.awssdk.services.s3.model.S3Exception: Access
Denied. (Service: S3, Status Code: 403,");
+ "software.amazon.awssdk.services.s3.model.S3Exception: Access
Denied (Service: S3, Status Code: 403,");
Review Comment:
Suggestion: use RegEx for account for both cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
