MonkeyCanCode commented on code in PR #3649:
URL: https://github.com/apache/polaris/pull/3649#discussion_r2766864907


##########
helm/polaris/Chart.yaml:
##########
@@ -37,3 +37,20 @@ maintainers:  # Maintainers section is kept only to satisfy 
the Helm Chart Spec
   - name: gerrit-k
   - name: snazy
   - name: flyrain
+annotations:
+  artifacthub.io/links: |
+    - name: Homepage
+      url: https://polaris.apache.org/
+    - name: Source Code
+      url: https://github.com/apache/polaris
+    - name: Documentation
+      url: https://polaris.apache.org/
+    - name: Support
+      url: https://github.com/apache/polaris/issues
+  artifacthub.io/license: Apache-2.0
+  artifacthub.io/category: big-data
+  artifacthub.io/screenshots: |
+    - title: Polaris Architecture

Review Comment:
   Curious, why these screenshots as they are blog specific?



##########
helm/polaris/Chart.yaml:
##########
@@ -37,3 +37,20 @@ maintainers:  # Maintainers section is kept only to satisfy 
the Helm Chart Spec
   - name: gerrit-k
   - name: snazy
   - name: flyrain
+annotations:
+  artifacthub.io/links: |
+    - name: Homepage
+      url: https://polaris.apache.org/
+    - name: Source Code
+      url: https://github.com/apache/polaris
+    - name: Documentation
+      url: https://polaris.apache.org/
+    - name: Support
+      url: https://github.com/apache/polaris/issues
+  artifacthub.io/license: Apache-2.0
+  artifacthub.io/category: big-data

Review Comment:
   I am not sure if `big-data` is valid for artifacthub.io/category:
   ```
   artifacthub.io/category (string, see example below)
   This annotation allows publishers to provide the package's category. Please 
use only one category from the following list: ai-machine-learning, database, 
integration-delivery, monitoring-logging, networking, security, storage or 
streaming-messaging.
   ```



##########
helm/polaris/Chart.yaml:
##########
@@ -37,3 +37,20 @@ maintainers:  # Maintainers section is kept only to satisfy 
the Helm Chart Spec
   - name: gerrit-k
   - name: snazy
   - name: flyrain
+annotations:
+  artifacthub.io/links: |
+    - name: Homepage
+      url: https://polaris.apache.org/
+    - name: Source Code
+      url: https://github.com/apache/polaris
+    - name: Documentation
+      url: https://polaris.apache.org/

Review Comment:
   I think the documentation page is 
`https://polaris.apache.org/releases/1.3.0/` and we will likely need to bump 
this version as we move to the next release.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to