obelix74 commented on code in PR #3616:
URL: https://github.com/apache/polaris/pull/3616#discussion_r2771688289
##########
polaris-core/src/main/java/org/apache/polaris/core/metrics/iceberg/MetricsRecordConverter.java:
##########
@@ -115,6 +116,20 @@ public ScanReportBuilder namespace(List<String> namespace)
{
return this;
}
+ /**
+ * Sets the timestamp for the metrics record.
+ *
+ * <p>This should be the time the metrics report was received by the
server, which may differ
+ * from the time it was recorded by the client.
+ *
+ * @param timestamp the timestamp
+ * @return this builder
+ */
+ public ScanReportBuilder timestamp(Instant timestamp) {
+ this.timestamp = timestamp;
Review Comment:
@dimas-b noticed this bug when I was rebasing
https://github.com/apache/polaris/pull/3385 to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
