MonkeyCanCode commented on code in PR #3679: URL: https://github.com/apache/polaris/pull/3679#discussion_r2772026324
########## tools/rustfs-testcontainer/src/main/java/org/apache/polaris/test/rustfs/RustfsAccess.java: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.test.rustfs; + +import java.net.URI; +import java.util.Map; +import java.util.Optional; +import software.amazon.awssdk.core.sync.RequestBody; +import software.amazon.awssdk.services.s3.S3Client; + +/** + * Provides access to Rustfs via a preconfigured S3 client and providing the by default randomized + * bucket and access/secret keys. + * + * <p>Annotate JUnit test instance or static fields or method parameters of this type with {@link + * Rustfs}. + */ +// CODE_COPIED_TO_POLARIS from Project Nessie 0.104.2 +public interface RustfsAccess { Review Comment: Using `S3Access` sounds great but I am not sure if they are truly re-usable (e.g. switch from minio to rustfs would required couple changes already such as environments variables used by them as well as the domain with port when using virtual host style access). My only concern is, with generic naming, will that be more confusing as we can't really promised switching to another s3 compatible will work (e.g. rustfs to seaweedfs)? I am assuming we would drop minio one day and maybe do the change around that time instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
