snazy commented on code in PR #3687:
URL: https://github.com/apache/polaris/pull/3687#discussion_r2774777024


##########
spec/generated/bundled-polaris-catalog-service.yaml:
##########
@@ -4452,6 +4589,13 @@ components:
           message: The given namespace already exists
           type: AlreadyExistsException
           code: 409
+    NamespaceNotEmptyError:

Review Comment:
   This new one seems to demand other code changes.



##########
spec/generated/bundled-polaris-catalog-service.yaml:
##########
@@ -2715,14 +2774,18 @@ components:
         format-version:
           type: integer
           minimum: 1
-          maximum: 2
+          maximum: 3

Review Comment:
   Should we potentially add some safeguards to allow/disallow v3? (in a 
separate PR, of course)



##########
spec/generated/bundled-polaris-catalog-service.yaml:
##########
@@ -2845,6 +2913,10 @@ components:
           type: string
         metadata-location:
           type: string
+        overwrite:

Review Comment:
   This one cries for a feature/configuration toggle?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to