dimas-b commented on code in PR #3385:
URL: https://github.com/apache/polaris/pull/3385#discussion_r2775346205
##########
runtime/service/src/main/java/org/apache/polaris/service/config/ServiceProducers.java:
##########
@@ -224,6 +225,20 @@ public PolarisMetaStoreManager polarisMetaStoreManager(
return metaStoreManagerFactory.getOrCreateMetaStoreManager(realmContext);
}
+ /**
+ * Produces a {@link MetricsPersistence} bean for the current request. The
default implementation
+ * returns a no-op instance. Persistence backends that support metrics
storage (e.g., JDBC with
+ * metrics schema) should provide an alternative producer that returns a
functional
+ * implementation.
+ *
+ * @return a MetricsPersistence implementation for the current realm
+ */
+ @Produces
+ @RequestScoped
+ public MetricsPersistence metricsPersistence() {
+ return MetricsPersistence.NOOP;
Review Comment:
Do you plan wiring `JdbcMetricsPersistence` to CDI in a follow-up PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
