huaxingao commented on code in PR #3584:
URL: https://github.com/apache/polaris/pull/3584#discussion_r2776446157
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/QueryGenerator.java:
##########
@@ -231,22 +316,55 @@ static QueryFragment generateWhereClause(
@Nonnull Set<String> tableColumns,
@Nonnull Map<String, Object> whereEquals,
@Nonnull Map<String, Object> whereGreater) {
+ return generateWhereClauseExtended(
+ tableColumns, whereEquals, whereGreater, Map.of(), Set.of(), Set.of());
+ }
+
+ private static void validateColumns(
+ @Nonnull Set<String> tableColumns, @Nonnull Set<String> columns) {
+ for (String column : columns) {
+ if (!tableColumns.contains(column) && !column.equals("realm_id")) {
+ throw new IllegalArgumentException("Invalid query column: " + column);
Review Comment:
Makes sense. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
