adutra commented on code in PR #3409:
URL: https://github.com/apache/polaris/pull/3409#discussion_r2789314130
##########
runtime/service/src/main/java/org/apache/polaris/service/storage/PolarisStorageIntegrationProviderImpl.java:
##########
@@ -54,15 +55,21 @@ public class PolarisStorageIntegrationProviderImpl
implements PolarisStorageInte
private final StsClientProvider stsClientProvider;
private final Optional<AwsCredentialsProvider> stsCredentials;
private final Supplier<GoogleCredentials> gcpCredsProvider;
+ private final StorageConfiguration storageConfiguration;
+ private final RealmConfig realmConfig;
@SuppressWarnings("CdiInjectionPointsInspection")
@Inject
public PolarisStorageIntegrationProviderImpl(
- StorageConfiguration storageConfiguration, StsClientProvider
stsClientProvider, Clock clock) {
- this(
- stsClientProvider,
- Optional.ofNullable(storageConfiguration.stsCredentials()),
- storageConfiguration.gcpCredentialsSupplier(clock));
+ StorageConfiguration storageConfiguration,
+ StsClientProvider stsClientProvider,
+ RealmConfig realmConfig,
+ Clock clock) {
+ this.storageConfiguration = storageConfiguration;
+ this.stsClientProvider = stsClientProvider;
+ this.stsCredentials = Optional.empty();
+ this.gcpCredsProvider = storageConfiguration.gcpCredentialsSupplier(clock);
+ this.realmConfig = realmConfig;
}
public PolarisStorageIntegrationProviderImpl(
Review Comment:
Some further cleanup (in a follow-up PR) would be nice here, as this
constructor is now only used in 2 tests but it complicates the logic for
resolving the creds quite a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
