flyrain commented on code in PR #3724:
URL: https://github.com/apache/polaris/pull/3724#discussion_r2796041360
##########
polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizableOperation.java:
##########
@@ -144,7 +145,7 @@ public enum PolarisAuthorizableOperation {
DROP_VIEW(VIEW_DROP),
VIEW_EXISTS(VIEW_LIST),
RENAME_VIEW(VIEW_DROP, EnumSet.of(VIEW_LIST, VIEW_CREATE)),
- REPORT_METRICS(EnumSet.noneOf(PolarisPrivilege.class)),
+ REPORT_METRICS(TABLE_REPORT_METRICS),
Review Comment:
Do we need to introduce a new privilege? My concern is the new one is
probably not necessary, and the way we introduce it will also break existing
users using the report-metrics endpoint.
Given the metrics endpoint is per-table, can we use the similar approach as
credential refresh endpoint does, which uses the privilge TABLE_READ_PROPERTIES?
https://github.com/apache/polaris/blob/849039371b59c9ffba088f6ba6a0fffb6d9f58fc/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java#L729
```suggestion
REPORT_METRICS(TABLE_READ_PROPERTIES),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
