adutra opened a new pull request, #3790: URL: https://github.com/apache/polaris/pull/3790
The logic in `polaris.containerPorts` has been improved to prevent duplicate ports in a `Deployment`. Summary of changes: - Container ports are keyed by port number instead of name to prevent duplicate `containerPort` entries (invalid in Kubernetes) - Validate that both port numbers and port names are unique - Extract validation logic into `polaris.validateContainerPort` helper template - Fix documentation of `targetPort`: this field must be a number - Update tests to reflect new validation behavior <!-- ๐ Describe what changes you're proposing, especially breaking or user-facing changes. ๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more. --> ## Checklist - [ ] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [ ] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes # - [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [ ] ๐ก Added comments for complex logic - [ ] ๐งพ Updated `CHANGELOG.md` (if needed) - [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
