obelix74 commented on code in PR #3385:
URL: https://github.com/apache/polaris/pull/3385#discussion_r2842649819
##########
persistence/relational-jdbc/src/main/resources/h2/schema-metrics-v1.sql:
##########
@@ -99,6 +99,10 @@ COMMENT ON TABLE scan_metrics_report IS 'Scan metrics
reports as first-class ent
-- Index for retention cleanup by timestamp
CREATE INDEX IF NOT EXISTS idx_scan_report_timestamp ON
scan_metrics_report(realm_id, timestamp_ms);
+-- Index for query lookups by catalog_id and table_id
+-- This index is critical for efficient queries that filter by catalog_id and
table_id
Review Comment:
Changed to:
```
-- Index for query lookups by catalog_id and table_id
-- This index supports efficient queries that filter by catalog_id and
table_id.
-- Including timestamp_ms enables time-range filtering and sorting
without additional index lookups.
```
##########
runtime/service/build.gradle.kts:
##########
@@ -31,6 +31,7 @@ dependencies {
implementation(project(":polaris-api-iceberg-service"))
implementation(project(":polaris-api-catalog-service"))
+ compileOnly(project(":polaris-relational-jdbc"))
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
