snazy commented on code in PR #3796: URL: https://github.com/apache/polaris/pull/3796#discussion_r2845956884
########## site/content/community/release-guides/manual-release-guide.md: ########## @@ -139,8 +139,13 @@ echo "x.y.z" > version.txt and update the version in the Helm Chart in: -* `helm/polaris/Chart.yaml` +* `helm/polaris/Chart.yaml` + - update `version` and `appVersion` fields + - update the `Documentation` link in the `artifacthub.io/links` annotation to point to + `https://polaris.apache.org/releases/x.y.z-incubating/` * `helm/polaris/README.md` +* `helm/polaris/values.yaml` + - update the `image.tag` field from `"latest"` to `"x.y.z-incubating"` Review Comment: ```suggestion - update the `image.tag` field from `"latest"` to `"x.y.z"` ``` ########## helm/polaris/.helmignore: ########## @@ -40,7 +40,10 @@ .idea/ *.tmproj .vscode/ +# Helm chart documentation helm.md helm.md.gotmpl +# Helm chart testing, CI and release management ci/ tests/ +artifacthub-repo.yml Review Comment: Nit: mind adding a trailing newline? ########## site/content/community/release-guides/manual-release-guide.md: ########## @@ -139,8 +139,13 @@ echo "x.y.z" > version.txt and update the version in the Helm Chart in: -* `helm/polaris/Chart.yaml` +* `helm/polaris/Chart.yaml` + - update `version` and `appVersion` fields + - update the `Documentation` link in the `artifacthub.io/links` annotation to point to + `https://polaris.apache.org/releases/x.y.z-incubating/` Review Comment: ```suggestion `https://polaris.apache.org/releases/x.y.z/` ``` ########## .github/workflows/release-3-build-and-publish-artifacts.yml: ########## @@ -477,9 +477,14 @@ jobs: # Copy the updated index.yaml to the dist dev directory exec_process cp "$WORK_DIR/index.yaml" "${dist_dev_dir}/helm-chart/index.yaml" - # Commit the updated index + # Copy the artifacthub-repo.yml to the dist dev directory + exec_process cp "helm/polaris/artifacthub-repo.yml" "${dist_dev_dir}/helm-chart/artifacthub-repo.yml" + exec_process cd "${dist_dev_dir}" - exec_process svn commit --username "$SVN_USERNAME" --password "$SVN_PASSWORD" --non-interactive -m "Update Helm index for ${version_without_rc} RC${rc_number}" + # Add artifacthub-repo.yml if not already versioned + exec_process svn info helm-chart/artifacthub-repo.yml > /dev/null 2>&1 || exec_process svn add helm-chart/artifacthub-repo.yml Review Comment: Maybe this? ```suggestion exec_process svn add helm-chart/artifacthub-repo.yml || true ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
