flyrain commented on code in PR #3385: URL: https://github.com/apache/polaris/pull/3385#discussion_r2850114474
########## site/content/in-dev/unreleased/configuration/config-sections/smallrye-polaris_persistence_metrics.md: ########## @@ -0,0 +1,35 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +title: smallrye-polaris_persistence_metrics +build: + list: never + render: never +--- + +Configuration for selecting the (`org.apache.polaris.core.persistence.metrics.MetricsPersistence`) implementation. + +This configuration allows selecting the metrics persistence backend independently from the entity metastore. Available types include: + + * `noop` (default) - No persistence, metrics are discarded Review Comment: I believe the semantics of persisting or not metrics collection should remain orthogonal to the choice of persistence backend. Whether metrics are collected is a functional concern. It can be expressed either as a feature level configuration or by selecting a specific `PolarisMetricsReporter`, for example `default` versus `persisting`. In contrast, the persistence type is purely an implementation detail. Coupling these two dimensions introduces implicit behavior, makes the configuration harder to reason about, and reduces flexibility as we evolve the system. If the `persisting` reporter is selected, metrics should always be persisted. The underlying metastore implementation should remain consistent with `polaris.persistence.type`. We are not in a position to support a mixed setup where one part of Polaris uses one `MetaStoreManager` implementation and another part uses a different one. That would significantly increase complexity in lifecycle management, transactions, and operational guarantees. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
