obelix74 commented on code in PR #3385: URL: https://github.com/apache/polaris/pull/3385#discussion_r2850765578
########## runtime/service/src/main/java/org/apache/polaris/service/persistence/NoopRequestIdSupplier.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.persistence; + +import io.quarkus.arc.DefaultBean; +import jakarta.enterprise.context.ApplicationScoped; +import org.apache.polaris.core.context.RequestIdSupplier; + +/** + * Default (fallback) implementation of {@link RequestIdSupplier} that returns null. + * + * <p>This bean is used when no other RequestIdSupplier is available (e.g., in Admin CLI or other + * non-request contexts). It's marked with {@link DefaultBean} so it can be overridden by other + * implementations like {@link ServiceRequestIdSupplier}. + */ +@ApplicationScoped +@DefaultBean +public class NoopRequestIdSupplier implements RequestIdSupplier { Review Comment: Removed in e8fd1e484. ########## runtime/service/src/main/java/org/apache/polaris/service/persistence/ServiceRequestIdSupplier.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.persistence; + +import jakarta.enterprise.context.RequestScoped; +import org.apache.polaris.core.context.RequestIdSupplier; +import org.apache.polaris.service.tracing.RequestIdFilter; +import org.jboss.resteasy.reactive.server.core.CurrentRequestManager; +import org.jboss.resteasy.reactive.server.core.ResteasyReactiveRequestContext; +import org.jboss.resteasy.reactive.server.jaxrs.ContainerRequestContextImpl; + +/** + * Request-scoped implementation of {@link RequestIdSupplier} that obtains the request ID from the + * RESTEasy Reactive request context. + */ +@RequestScoped +public class ServiceRequestIdSupplier implements RequestIdSupplier { Review Comment: Removed in e8fd1e484. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
