adutra commented on code in PR #3922:
URL: https://github.com/apache/polaris/pull/3922#discussion_r2874369799


##########
helm/polaris/templates/deployment.yaml:
##########
@@ -27,6 +27,10 @@ metadata:
     {{- if .Values.podLabels }}
     {{- tpl (toYaml .Values.podLabels) . | nindent 4 }}
     {{- end }}
+  {{- if .Values.deploymentAnnotations }}

Review Comment:
   I've seen some charts apply the same labels to deployments and the pods they 
create – so I'm not entirely surprised. But I agree this could be better 
handled by a dedicated `deploymentLabels` option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to