gh-yzou commented on code in PR #3729: URL: https://github.com/apache/polaris/pull/3729#discussion_r2874911112
########## polaris-core/src/main/java/org/apache/polaris/core/connection/GcpAuthenticationParametersDpo.java: ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.core.connection; + +import com.fasterxml.jackson.annotation.JsonProperty; +import jakarta.annotation.Nonnull; +import java.util.HashMap; +import java.util.Map; +import java.util.Objects; +import org.apache.iceberg.CatalogProperties; +import org.apache.iceberg.rest.auth.AuthProperties; +import org.apache.polaris.core.admin.model.AuthenticationParameters; +import org.apache.polaris.core.admin.model.GcpAuthenticationParameters; +import org.apache.polaris.core.credentials.PolarisCredentialManager; + +/** + * See {@link org.apache.iceberg.rest.RESTUtil#configHeaders(Map)} and {@link + * org.apache.iceberg.rest.auth.AuthManagers#loadAuthManager(String, Map)} for why we do this. + */ +public class GcpAuthenticationParametersDpo extends AuthenticationParametersDpo { + private final String quotaProject; + private final String remoteWarehouseName; + + public GcpAuthenticationParametersDpo( + @JsonProperty(value = "quotaProject", required = true) @Nonnull String quotaProject, + @JsonProperty(value = "remoteWarehouseName", required = true) @Nonnull + String remoteWarehouseName) { + super(AuthenticationType.GCP.getCode()); + this.quotaProject = quotaProject; Review Comment: @XJDKC i think i got your point about the part that ConnectionInfo is used to configure all information needed for the remote catalog includes the authentication information, and AuthenticationParameters is only suppose to include configs related to authentication. Given that this is the boundary we set today for all those fields, i think we should be consistent on this. How about the ServiceIdentityInfo fields, do you think we can extend this field to include any extra information that is needed to help establish connections with GCP catalog, for example, if those are BigLake specific, we can have BigLakeIdentifier etc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
