dimas-b commented on code in PR #3908:
URL: https://github.com/apache/polaris/pull/3908#discussion_r2878934106
##########
polaris-core/src/testFixtures/java/org/apache/polaris/core/persistence/BasePolarisMetaStoreManagerTest.java:
##########
@@ -283,6 +283,12 @@ protected void testLoadResolvedEntitiesById() {
polarisTestMetaStoreManager.testLoadResolvedEntitiesById();
}
+ /** test that grantee and securable grant records are loaded from the
correct store methods */
+ @Test
+ protected void testLoadResolvedEntitiesGranteeVsSecurableRecords() {
+
polarisTestMetaStoreManager.testLoadResolvedEntitiesGranteeVsSecurableRecords();
Review Comment:
How does this test ensure that the impl. behaves "correctly"? Current test
code only guarantees that no exception is thrown 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
