adnanhemani commented on PR #3924: URL: https://github.com/apache/polaris/pull/3924#issuecomment-3994244881
Couple of more higher-level thoughts: * I don't agree with different endpoints for each of the metric types. If we started applying this principle to other endpoints (such as Events), things would get out of hand VERY quickly. Instead, we should aim towards a singular `GET /metrics` (or similar) endpoint that gives you back all the metrics types (Scan, Commit, etc. - given that this could also grow in the future), where metric type is something that you can ask for as a filter. I believe in this even if this requires a full re-factor of the Metrics data model. * As per https://lists.apache.org/thread/tr4mhf1hst3zmp0tcp77h248bjbtmwd9, I don't think the community has come to an agreement for using "markdown proposals". I think it's fine if you wish to continue collaborating here, but IMO GitHub and markdown files aren't the best tools for collaboration. I think this proposal won't be "mergable" in its state as a PR until there is consensus built on the ML thread I linked (and there are multiple people who are not for the proposal). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
