dimas-b commented on code in PR #3352:
URL: https://github.com/apache/polaris/pull/3352#discussion_r2884909975
##########
persistence/relational-jdbc/src/main/resources/cockroachdb/schema-v3.sql:
##########
Review Comment:
Should we go to v4 right away (to match the latest PostgreSQL schema)? Do we
need to support older schemas for CockroachDB?
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DatabaseType.java:
##########
@@ -36,28 +45,128 @@ public String getDisplayName() {
return displayName;
}
+ /**
+ * Returns the latest schema version available for this database type. This
is used as the default
+ * schema version for new installations.
+ */
+ public int getLatestSchemaVersion() {
+ return switch (this) {
+ case POSTGRES -> 3; // PostgreSQL has schemas v1, v2, v3
Review Comment:
Is the latest schema v4 now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
