obelix74 commented on PR #3924: URL: https://github.com/apache/polaris/pull/3924#issuecomment-3999938447
> I think the persistence layer is a precondition for this API, it seems that we [don't persist](https://github.com/apache/polaris/blob/main/runtime/service/src/main/java/org/apache/polaris/service/events/listeners/PolarisPersistenceEventListener.java#L39) most of the events? @dimas-b do you happen to know, am I looking the right point where we persist the events? You are correct. I added a listener that extends InMemoryBufferEventListener and persists many more events: Table Operations: • AfterLoadTableEvent • AfterCreateTableEvent • AfterUpdateTableEvent • BeforeDropTableEvent • AfterDropTableEvent • AfterLoadCredentialsEvent Namespace Operations: • AfterCreateNamespaceEvent • AfterUpdateNamespacePropertiesEvent • BeforeDropNamespaceEvent • AfterDropNamespaceEvent • AfterListTablesEvent • AfterListNamespacesEvent View Operations: • AfterCreateViewEvent • AfterReplaceViewEvent • BeforeDropViewEvent • AfterDropViewEvent • AfterLoadViewEvent • AfterListViewsEvent Catalog Operations: • AfterCreateCatalogEvent • AfterCommitTransactionEvent I have not persisted principal / role management, policy events and a few others (I should add them). Adding a section to the proposal highlighting this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
