dimas-b commented on code in PR #3940:
URL: https://github.com/apache/polaris/pull/3940#discussion_r2893009684


##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/resolver/PolarisResolutionManifest.java:
##########
@@ -57,11 +57,11 @@ public class PolarisResolutionManifest implements 
PolarisResolutionManifestCatal
   private final Resolver primaryResolver;
   private final PolarisDiagnostics diagnostics;
 
-  private final Map<Object, Integer> pathLookup = new HashMap<>();
+  private final Map<ResolvedPathKey, Integer> pathLookup = new HashMap<>();

Review Comment:
   Actually, what I wrote above is not exactly what the old PR was doing... I 
guess I was dreaming a bit 😅 
   
   In any case, what I mean is this:
   
   ```
   Handle h = resolutionManifest.addPath(...);
   // resolve
   PolarisResolvedPathWrapper r = h.get();
   ```
   WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to