machov commented on PR #3939: URL: https://github.com/apache/polaris/pull/3939#issuecomment-4025561183
Do we need a v5 (since this is “just” additional DDL)? Yes. v5 schema bump is the safest way to ensure the indexes get applied for *existing* installs. Updating v4 only helps fresh installs; it won’t automatically add indexes to databases already initialized at v4. Do we need to ship these indexes vs recommending in docs/code? We should ship them. This change takes create_namespace from 30s+ (timeouts) down to ~<2s, so it’s not an optional tuning tip at scale. Shipping via schema/migrations avoids putting manual DDL burden on operators. (Happy to also add a short doc note explaining the rationale.) Do we need this in 1.4? Yes. I can backport it to the 1.4.x line as a post-release schema bump (v5) with migration notes (what indexes are created + expected impact/lock behavior). This way 1.4 users get the fix through the normal upgrade flow without changing already-shipped v4 semantics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
