Subham-KRLX commented on code in PR #3960:
URL: https://github.com/apache/polaris/pull/3960#discussion_r2931830018
##########
runtime/service/src/main/java/org/apache/polaris/service/persistence/PersistenceConfiguration.java:
##########
@@ -37,4 +37,11 @@ public interface PersistenceConfiguration {
default boolean isAutoBootstrap() {
return autoBootstrapTypes().contains(type());
}
+
+ /**
+ * The type of the {@link
org.apache.polaris.persistence.relational.jdbc.DataSourceResolver} to
+ * use. Only applicable when using JDBC persistence.
+ */
+ @WithDefault("polaris")
+ String dataSourceResolver();
Review Comment:
@adutra @dimas-b I will rename the identifier to "default" and update the
config property to polaris.persistence.datasource-resolver.type as suggested.
Regarding the broader discussion on module placement — I agree a dedicated
polaris-relational-jdbc-runtime module sounds like a clean approach for keeping
Quarkus/Agroal dependencies separate. Happy to tackle that as a follow-up or
incorporate it here if you'd prefer. Will push the fixes along with CI fixes
shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
